chore: Fix upload script to correctly add new records, even if they re-use the same remote settings id as a different record. #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-use the same remote settings id as a different record.
daleharvey
approved these changes
Jun 5, 2024
Correct, no bump required. Thanks for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied and pasted a section of search-config-v2 to create a new engine. When I did so, I kept the id/schema/last_modified records. The upload.py script silently failed to upload these as remote settings thought they were already there. Maybe remote settings should have complained a bit louder, but in any case, I don't think we should be attempting to set those fields.