Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bz#1823729 - Listen only for status on tab updated #2659

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

dannycolin
Copy link
Collaborator

See https://bugzilla.mozilla.org/show_bug.cgi?id=1823729#c9

Before submitting your pull request

  • I agree to license my code under the MPL 2.0 license.
  • I rebased my work on top of the main branch.
  • I ran npm test and all tests passed.
  • I added test coverages if relevant.

Description

tl;dr If a tab never reach the complete readyState, we can end up in a situation where a frequent (and likely never ending?) sequence of tabs.onUpdated events are triggered. This can create performance issues in a session with a large amount of tabs. By only tracking the onUpdated events we really need, we can considerably reduce the numbers of events and prevent any performance issues.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1823729#c9

Type of change

Select all that apply.

  • Bug fix
  • New feature
  • Major change (fix or feature that would cause existing functionality to work differently than in the current version)

Tag issues related to this pull request:

@rafeerahman rafeerahman merged commit 97891f6 into mozilla:main Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants