Python: generate type stubs for all user functions #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
mypy-types
branch
3 times, most recently
from
feb0ff4
to
14f274a
Compare
mhammond
approved these changes
Apr 25, 2023
badboy
force-pushed
the
mypy-types
branch
3 times, most recently
from
1c737ed
to
835fc4b
Compare
|
What's the status of this? The changes seem approved. Does it only need a rebase? (Is help with the rebase wanted?) |
Ah yes, this once again needs a rebase. It fell through a bit due to other work, but I can take this up today. |
1. Methods of a callback expect `self` as the first argument (instance methods) 2. `contextlib.contextmanager`-methods require _some_ args (according to `mypy`), so we use a catchall (where nothing is fine too)
badboy
force-pushed
the
mypy-types
branch
2 times, most recently
from
04ee66a
to
b4aa69c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After getting asked about it the other day on reddit I figured I give it a go.
Turns out generating the right types in Python is possible and pleases mypy when used in Glean as well (for the most part).
There's some not-yet fixed cases, I want to add some testing and ensure this reliably works, so marking this as WIP for the moment.