Improve error outputs for Python code #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendk
requested changes
May 24, 2023
|
Thank you for giving this a pass. I'm not sure what the final product should be, but I don't think the current code is correct and I'm glad someone is pushing for changes. |
heinrich5991
force-pushed
the
pr_py_error_names
branch
3 times, most recently
from
a4f2f7b
to
5a91b36
Compare
Fixes mozilla#1555. Before: ``` >>> libtw2_huffman.decompress(b"") Traceback (most recent call last): […] libtw2_huffman.UniFFIExceptionTmpNamespace.InvalidInput: DecompressionError.InvalidInput('input is not a valid huffman compression') ``` After: ``` >>> libtw2_huffman.decompress(b"") Traceback (most recent call last): […] libtw2_huffman.DecompressionError.InvalidInput: input is not a valid huffman compression ```
heinrich5991
force-pushed
the
pr_py_error_names
branch
from
5a91b36
to
d5b6eda
Compare
bendk
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1555.
Before:
After: