Add support for field defaults to proc-macro frontend #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
changed the title
jplatte
force-pushed
the
jplatte/record-field-default
branch
2 times, most recently
from
3b86514
to
188d264
Compare
mhammond
approved these changes
May 25, 2023
| }, | ||
| FieldMetadata { | ||
| name: "age".into(), | ||
| ty: Type::U16, | ||
| default: None, |
There was a problem hiding this comment.
missed opportunity here for default: Default::default() :)
| @@ -104,6 +104,12 @@ will fail). | |||
| pub struct MyRecord { | |||
| pub field_a: String, | |||
| pub field_b: Option<Arc<MyObject>>, | |||
| // Fields can have a default value. | |||
| // Currently, only string, integer, float and boolean literals are supported as defaults. | |||
There was a problem hiding this comment.
I wonder if it is worth adding something like "these work the same way as documented for UDL files" or similar (the docs need a restructure, but udl/structs.md does describe this in some detail)
jplatte
force-pushed
the
jplatte/record-field-default
branch
from
188d264
to
a9dfd35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1559.