Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): Add suggested webpack usage #194

Merged
merged 4 commits into from
Aug 1, 2019
Merged

docs(README): Add suggested webpack usage #194

merged 4 commits into from
Aug 1, 2019

Conversation

fregante
Copy link
Contributor

Closes #156 as suggested in #156 (comment) and as used by Refined GitHub

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepend docs(README): to your commit title.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fregante fregante changed the title Add suggested webpack usage docs(README): Add suggested webpack usage Jul 25, 2019
@Rob--W
Copy link
Member

Rob--W commented Jul 25, 2019

Thanks for the changes. I will discuss this PR with rpl next Thursday.

Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, just a couple of nits:

  • tweaking the title a bit
  • linking the section in the TOC

README.md Outdated Show resolved Hide resolved
@rpl rpl merged commit 44a473d into mozilla:master Aug 1, 2019
@fregante fregante deleted the webpack branch August 1, 2019 16:53
@caitmuenster
Copy link

Thanks so much for the update, @fregante! 🎉 Your contribution has been added to our recognition wiki.

Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you!

@fregante
Copy link
Contributor Author

fregante commented Aug 6, 2019

@caitmuenster
Copy link

Thanks @fregante! Your profile is vouched. ✨

Welcome onboard! We look forward to seeing you around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to use webextension-polyfill with webpack.ProvidePlugin
4 participants