Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressiveLightMap: Fix uv regression. #27692

Merged
merged 1 commit into from
Feb 6, 2024
Merged

ProgressiveLightMap: Fix uv regression. #27692

merged 1 commit into from
Feb 6, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 6, 2024

Related issue: #27608

Description

ProgressiveLightMap enhance a built-in material via onBeforeCompile() and injects uv related defines which conflicts with the solution in #27608. To make ProgressiveLightMap work again, it must define the uv1 attribute by itself.

@Mugen87 Mugen87 added this to the r162 milestone Feb 6, 2024
@Mugen87 Mugen87 merged commit ca69555 into mrdoob:dev Feb 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant