Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Update fflate #27883

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Examples: Update fflate #27883

merged 1 commit into from
Mar 8, 2024

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Mar 8, 2024

Related issue: N/A

Description

Updates fflate to v0.8.2. This make it easier to use their types, since TypeScript declaration files do not always resolve correctly on earlier versions of fflate.

The only breaking change mentioned in fflate's changelog is a change in the signature of inflateSync. I could not find any usages of this function in three.js.

The updated code was copied from the distributed ./esm/browser.js file (while keeping the header added in three.js).

@mrdoob mrdoob added this to the r163 milestone Mar 8, 2024
@mrdoob mrdoob merged commit 572e7fc into mrdoob:dev Mar 8, 2024
11 checks passed
@Methuselah96 Methuselah96 deleted the update-fflate branch March 8, 2024 03:40
@Methuselah96 Methuselah96 mentioned this pull request Mar 22, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants