Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstancedMesh: Add clone and dispose method for morphTexture #27952

Merged

Conversation

RenaudRohlinger
Copy link
Collaborator

@RenaudRohlinger RenaudRohlinger commented Mar 20, 2024

Related issue: #27928 #27669 #27768

Description
WebGLRenderer: The copy method wasn't cloning the new morphTexture DataTexture and the texture was never cleaned when the InstancedMesh disposed.

WebGPURenderer: When using nodes, it is possible to create instanced skinning meshes with morph targets. In such cases, morphTexture is undefined. This update also includes a cleanup of missing code in an example.

This contribution is funded by Utsubo

@RenaudRohlinger RenaudRohlinger added this to the r163 milestone Mar 20, 2024
Copy link

github-actions bot commented Mar 20, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
670.7 kB (166.3 kB) 670.8 kB (166.3 kB) +157 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
450.8 kB (108.9 kB) 450.8 kB (108.9 kB) +0 B

@RenaudRohlinger RenaudRohlinger changed the title InstancedMesh: Clone morphTexture in copy method InstancedMesh: Add clone and dispose method for morphTexture Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants