Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLShadowMap: Clean up #28194

Merged
merged 1 commit into from
Apr 23, 2024
Merged

WebGLShadowMap: Clean up #28194

merged 1 commit into from
Apr 23, 2024

Conversation

linbingquan
Copy link
Contributor

Related issue: #XXXX

Description

Removed the underline of the parameter.

I think the underline of the parameter should not be necessary.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
674.4 kB (167.1 kB) 674.4 kB (167.1 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
453.8 kB (109.5 kB) 453.8 kB (109.5 kB) +0 B

@Mugen87 Mugen87 added this to the r164 milestone Apr 23, 2024
@Mugen87 Mugen87 merged commit 1cacd91 into mrdoob:dev Apr 23, 2024
12 checks passed
@linbingquan linbingquan deleted the dev-shadowmap branch April 25, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants