Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Refreshs Geometry UI only if needed #28624

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Jun 11, 2024

Description

The current geometryChanged handler in all sidebar.geometry.xxx.js components do not filter the initiator object, so for example, updating geometry props of an object will trigger UI refresh for all other objects in the scene, which is wasteful.

This PR fixed that by filtering the initiator object at that handler, only refreshes UI if initiator is self.

@Mugen87 Mugen87 added this to the r166 milestone Jun 12, 2024
@Mugen87 Mugen87 merged commit dcf7202 into mrdoob:dev Jun 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants