Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSLNodeBuilder: Fix GL_ANGLE_multi_draw extension request. #29102

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

cmhhelgeson
Copy link
Contributor

Related issue: #28952

Description

Properly passes the proper Batched Mesh extension to the vertex stage. Fixes webgpu_mesh_batch sample in WebGL mode.

Copy link

github-actions bot commented Aug 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.1 kB (169.6 kB) 685.1 kB (169.6 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@Mugen87 Mugen87 added this to the r168 milestone Aug 9, 2024
@Mugen87 Mugen87 merged commit 795e25e into mrdoob:dev Aug 9, 2024
12 checks passed
@Mugen87 Mugen87 changed the title WebGPURenderer: Fix WebGLBackend getExtension() GLSLNodeBuilder: Fix GL_ANGLE_multi_draw extension request. Aug 9, 2024
@cmhhelgeson cmhhelgeson deleted the fix_get_extension branch August 9, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants