-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to specify a non-default table name when creating TinyD… #98
Conversation
Looks reasonable, thank you! While we're at it, could you also add a short test in |
Sure. |
…B instance: moved kwargs retrieval to the top of init method and added a tiny test.
moved kwargs pops to the top of init because storage instances don't recognize 'table' keyword |
I must have missed it in the first commit, but you introduced a new kwarg parameter to |
I've introduced a new |
May be a matter of taste but I think using a longer keyword argument like As an aside, I don't see why one would want to override the default table. Don't get me wrong, I like how you're handling it elegantly here, but I don't see why the application would care about the default table name. |
I cannot argue with this type of reasoning, this is a matter of taste. I just don't want to see "_default" keyword in my storage files. I find it ugly. Agreed on the parameter naming, though. |
…B instance: changed the default table param name from 'table' to 'default_table'
|
Merged! I hope to get a new release of TinyDB ready by the end of this week. Thanks everyone! |
…B instance.