Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input clef/key sig/time sig before cursor in note input mode #24763

Open
2 tasks done
oktophonie opened this issue Sep 17, 2024 · 8 comments · May be fixed by #24811
Open
2 tasks done

Input clef/key sig/time sig before cursor in note input mode #24763

oktophonie opened this issue Sep 17, 2024 · 8 comments · May be fixed by #24811
Labels
feature request Used to suggest improvements or new capabilities P1 Priority: High UX/interaction

Comments

@oktophonie
Copy link
Contributor

oktophonie commented Sep 17, 2024

Your idea

While in note input mode, a clef, key signature or time signature can be added from the palette. However, these items will be added not the point where the cursor currently is, but on the currently selected (i.e. last-inputted) note.

It would be more intuitive if these items were added at the cursor position.

Problem to be solved

For example: enter note input mode and enter these notes by typing D C B A:
image

Let's say I want a clef change before the next note. If I click one from the palette now, it will be inserted before the selected note (the A) - just as would happen outside of note input mode:
image

Since we're entering items sequentially it would make more sense (to me, anyway) to input it at the cursor position, so we'd get this:
image

As it is, you have to input the next note then input the clef, which feels a bit backwards.

Same goes for key/time sigs, which in this case are added to the previous bar, rather than the one where the cursor is.

Checklist

  • This request follows the guidelines for reporting issues
  • I have verified that this feature request has not been logged before, by searching the issue tracker for similar requests
@muse-bot muse-bot added the feature request Used to suggest improvements or new capabilities label Sep 17, 2024
@bkunda bkunda added the P1 Priority: High label Sep 17, 2024
@wizofaus
Copy link
Contributor

The commands "Add clef: bass" and "Add clef: treble" do work like this, even if it seems to require defining a custom keyboard shortcut for them.
In general I find there's a bit of a UX issue with how to specify that you want something to apply to a note just entered, vs the following note(s), as often both are useful operations.

sammik added a commit to sammik/MuseScore that referenced this issue Sep 18, 2024
@sammik
Copy link
Contributor

sammik commented Sep 18, 2024

see #24811

@wizofaus
Copy link
Contributor

Ok, but now how do you retrospectively add a clef change before the note just entered because you've realised it is further off the staff than you expected?

@wizofaus
Copy link
Contributor

(my personal preference is just to use the left arrow key to move the current position back before applying a change to an already entered note, but obviously needs agreement from those in charge of such decisions!)

@sammik
Copy link
Contributor

sammik commented Sep 18, 2024

(my personal preference is just to use the left arrow key to move the current position back before applying a change to an already entered note, but obviously needs agreement from those in charge of such decisions!)

exactly, as issue title says "Input clef/key sig/time sig before cursor in note input mode"

Before cursor, wherever it is.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Sep 19, 2024

Seems you're PR adds the clef before the next note, not after the last, resulting in the clef to be the first thing in the next measure rather than the last in the previous, so not what @oktophonie's image suggests?

sammik added a commit to sammik/MuseScore that referenced this issue Sep 19, 2024
@sammik
Copy link
Contributor

sammik commented Sep 19, 2024

Seems you're PR adds the clef before the next note, not after the last, resulting in the clef to be the first thing in the next measure rather than the last in the previous, so not what @oktophonie's image suggests?

I rechecked it. Working as expected (Simons third image).

@Jojo-Schmitz
Copy link
Contributor

You're right, it's my backport that does not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Used to suggest improvements or new capabilities P1 Priority: High UX/interaction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants