Read Prompt Support #722
Merged
Read Prompt Support #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Aug 21, 2021
interp/builtin.go
Outdated
| @@ -538,6 +544,14 @@ func (r *Runner) builtinCode(ctx context.Context, pos syntax.Pos, name string, a | |||
| } | |||
| } | |||
|
|
|||
| if prompt.provided { | |||
| if prompt.message == "" { | |||
There was a problem hiding this comment.
you could make this check inside case "-p", then you don't need provided at all - you'd just do message != "".
and you could also just do message := ""; I don't think the struct is necessary
There was a problem hiding this comment.
Ok gotcha, making the change 👍
|
@mvdan I left the |
mvdan
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @mvdan 👋
I have implemented the
read -pflag, as requested in issue #551. Included are new test cases to cover the added feature, as well as the integration of-pwith the existing code that handlesread. All test cases old and new are passing.Let me know if there are any changes still needed, and thanks for your hard work maintaining this library!