Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pwalign for pairwise sequence alignment if Biostrings >= 2.72.0 #23

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

nanxstats
Copy link
Owner

In Bioconductor 3.19 and Biostrings >= 2.72.0, the pairwise sequence alignment facilities are moved into the pwalign package. For maximum compatibility, this PR detects the installed Biostrings version at runtime and decides which package to use for pairwiseAlignment(), without introducing pwalign as an additional hard dependency.

@nanxstats
Copy link
Owner Author

The r-oldrel (R 4.3.x) check is failing because rjson 0.2.22 (released on 2024-08-20) now depends on R >= 4.4.0.

Since Bioconductor version bundles with the R version, all things released in Bioconductor >= 3.19 are built on R >= 4.4.x, this should not be a problem.

The GitHub Actions check will pass once R 4.5.0 is released and R 4.4.x becomes r-oldrel.

@nanxstats nanxstats merged commit bb82d29 into master Aug 30, 2024
5 of 6 checks passed
@nanxstats nanxstats deleted the pwalign branch August 30, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant