Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization of Command Responses #66

Closed
3 tasks done
dmknutsen opened this issue May 28, 2024 · 0 comments · Fixed by #67
Closed
3 tasks done

Standardization of Command Responses #66

dmknutsen opened this issue May 28, 2024 · 0 comments · Fixed by #67

Comments

@dmknutsen
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
cFS should have standardized command responses for commands that set a state/mode like enable/disable, on/off, true/false, start/stop/pause/resume, etc.

For those commands, the app should respond as describe below:

  • If the current setting is not in that commanded state,

    1. If the commanded state can be set successfully,
      a. Increment the command counter
      b. Send an INFO event that says command successfully executed
    2. otherwise,
      a. Increment the command error counter
      b. Send an ERROR event that says failed to execute the command
  • If the current setting is already in that commanded state,

    1. Increment the command counter, not command error counter
    2. Send an INFO event that says already in that state

The following command response does not align with the standard:
HK_RESET_COUNTERS_CC the successful event HK_RESET_CNTRS_CMD_EID is debug type

Describe the solution you'd like
Update logic to align with the standard.

Requester Info
Dan Knutsen
NASA Goddard

thnkslprpt added a commit to thnkslprpt/HK that referenced this issue May 29, 2024
dzbaker added a commit that referenced this issue Sep 26, 2024
…vent-type

Fix #66, Update Reset Counters event type to INFO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant