Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #77, deprecate PSP stubs from MD coverage test #78

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Aug 7, 2024

Checklist (Please check before submitting)

Describe the contribution
The PSP now provides the complete set of stubs. Local implementation should be removed.

Fixes #77

Testing performed
Build and run all tests

Expected behavior changes
None

System(s) tested on
Debian

Additional context
Needs to be coordinated with nasa/PSP#435

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey marked this pull request as draft August 7, 2024 19:51
@jphickey
Copy link
Contributor Author

jphickey commented Aug 7, 2024

I'm not sure yet if OMIT_DEPRECATED is enough here, so marking this as a draft. I may need to use a different approach.

@jphickey
Copy link
Contributor Author

I changed this to be a simple removal of the stubs (not deprecation) because one or the other of the builds will still fail depending on whether or not the PSP is included. There is no easy solution to getting forward+backward compatibility here.

The simplest path forward is to simply merge this in the same cycle as nasa/PSP#436 and note the dependency.

@jphickey jphickey marked this pull request as ready for review August 15, 2024 17:40
The PSP now provides the complete set of stubs.

IMPORTANT: This needs to be used in conjunction with nasa/PSP#436 to
get the complete set of stubs, otherwise linking will fail.
@dzbaker dzbaker merged commit e0e84eb into nasa:main Sep 23, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PSP stubs from MD
2 participants