Fix #432, buffer error in the VxWorks sysmon module #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cpu number to poll was not range checked until _after_ the memset. This is not the correct order of operations, it must range the element number in the array before writing/clearing it.
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 16, 2024
*Combines:* cFE equuleus-rc1+dev199 PSP equuleus-rc1+dev49 **Includes:** *cFS* - #791 - #796 *cFE* - nasa/cFE#2599 *PSP* - nasa/PSP#439 - nasa/PSP#436 Co-authored by: Andrew Liounis <aliounis@users.noreply.github.com> Co-authored by: Rich Landau <RichLandau@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This was referenced Sep 16, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 19, 2024
*Combines:* cFE equuleus-rc1+dev199 PSP equuleus-rc1+dev49 **Includes:** *cFS* - #791 - #796 *cFE* - nasa/cFE#2599 *PSP* - nasa/PSP#439 - nasa/PSP#436 Co-authored by: Andrew Liounis <aliounis@users.noreply.github.com> Co-authored by: Rich Landau <RichLandau@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
The cpu number to poll was not range checked until after the memset. This is not the correct order of operations, it must range the element number in the array before writing/clearing it.
Fixes #432
Testing performed
Run coverage tests
Expected behavior changes
No array overrun, no address sanitizer issues
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.