Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misspelled AppName string in tbl CFE_TBL_Validate function #1246

Closed
moschleg opened this issue Mar 18, 2021 · 0 comments · Fixed by #1247 or #1258
Closed

Misspelled AppName string in tbl CFE_TBL_Validate function #1246

moschleg opened this issue Mar 18, 2021 · 0 comments · Fixed by #1247 or #1258
Assignees
Milestone

Comments

@moschleg
Copy link

moschleg commented Mar 18, 2021

Describe the bug
The CFE_TBL_Validate( CFE_TBL_Handle_t TblHandle ) has a misspelling in the AppName string "UNKNWON"

To Reproduce
Directly visible in cfe\fsw\cfe-core\src\tbl\cfe_tbl_api.c -- int32 CFE_TBL_Validate( CFE_TBL_Handle_t TblHandle )

Expected behavior
The AppName array should be initialized to the same, consistent string 'UNKNOWN' as elsewhere in the code. However in the usual case, the AppName would almost immediately be replaced with the valid CFE_ES_GetAppName() value upon passing CFE_TBL_ValidateAccess() and would not have much impact other than test logging.

Code snips
cfe/fsw/cfe-core/src/tbl/cfe_tbl_api.c

int32 CFE_TBL_Validate( CFE_TBL_Handle_t TblHandle )
{
    int32                       Status;
    uint32                      ThisAppId;
    CFE_TBL_RegistryRec_t      *RegRecPtr;
    CFE_TBL_AccessDescriptor_t *AccessDescPtr;
    char                        AppName[OS_MAX_API_NAME]={"UNKNWON"};

System observed on:
noticed on code inspection

Additional context

Reporter Info
Mark O. Schlegel, Hammers Inc

skliper added a commit to skliper/cFE that referenced this issue Mar 22, 2021
@skliper skliper self-assigned this Mar 22, 2021
@skliper skliper added this to the 7.0.0 milestone Mar 22, 2021
skliper added a commit to skliper/cFE that referenced this issue Mar 23, 2021
astrogeco added a commit that referenced this issue Mar 24, 2021
Fix #1246, Typo in CFE_TBL_Validate AppName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants