Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_ES_MAX_EID incorrect #1320

Closed
skliper opened this issue Apr 13, 2021 · 1 comment · Fixed by #1594 or #1632
Closed

CFE_ES_MAX_EID incorrect #1320

skliper opened this issue Apr 13, 2021 · 1 comment · Fixed by #1594 or #1632
Assignees
@skliper
Labels
CFS-40 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 13, 2021

Is your feature request related to a problem? Please describe.
Max EID incorrect:

cFE/modules/es/fsw/inc/cfe_es_events.h

Line 46 in e80aae9

#define CFE_ES_MAX_EID 92

cFE/modules/es/fsw/inc/cfe_es_events.h

Line 1449 in e80aae9

#define CFE_ES_ERLOG_PENDING_ERR_EID 93

Describe the solution you'd like
Fix.

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Apr 13, 2021
@skliper skliper added the CFS-40 label Apr 13, 2021
@skliper skliper self-assigned this May 26, 2021
@skliper skliper mentioned this issue May 26, 2021
Closed
@skliper
Copy link
Contributor Author

skliper commented May 26, 2021

The real fix is #1583, order EIDs and remove the fragile MAX tracking by hand.

skliper added a commit to skliper/cFE that referenced this issue May 26, 2021
@skliper
Partial nasa#1320, Order event ids and remove max
9d24236
skliper added a commit to skliper/cFE that referenced this issue May 27, 2021
@skliper
Fix nasa#1320 nasa#1583, Order event ids and remove max
61ea145
@skliper skliper mentioned this issue Jun 1, 2021
Merged
skliper added a commit to skliper/cFE that referenced this issue Jun 9, 2021
@skliper
Fix nasa#1320 nasa#1583, Order event ids and remove max
45469db
skliper added a commit to skliper/cFE that referenced this issue Jun 17, 2021
@skliper
Fix nasa#1320 nasa#1583, Order event ids and remove max
961b752
astrogeco added a commit that referenced this issue Jun 23, 2021
@astrogeco
Merge pull request #1594 from skliper/fix1320-es_max_eid
63a5a31 
Fix #1320 #1583 #508, Event ID updates
@astrogeco astrogeco mentioned this issue Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
CFS-40 enhancement
Projects
None yet
Milestone
Caelum
1 participant
@skliper