Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CFE_FS_RunBackgroundFileDump to internal API #1393

Closed
skliper opened this issue Apr 20, 2021 · 0 comments · Fixed by #1463 or #1492
Closed

Move CFE_FS_RunBackgroundFileDump to internal API #1393

skliper opened this issue Apr 20, 2021 · 0 comments · Fixed by #1463 or #1492
Labels
CFS-41 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 20, 2021

Is your feature request related to a problem? Please describe.
CFE_FS_RunBackgroundFileDump is only used internally, shouldn't be exposed as external API

Describe the solution you'd like
Move to *_core_internal.h

Describe alternatives you've considered
None

Additional context
Code review, once moved would also benefit from #1387

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Apr 20, 2021
This was referenced Apr 30, 2021
Closed
Merged
jphickey added a commit to jphickey/cFE that referenced this issue Apr 30, 2021
@jphickey
Fix nasa#1393, Move CFE_FS_RunBackgroundFileDump to internal API
439a33d 
This function should only be called internally from ES and
therefore does not need to be in public API.
jphickey added a commit to jphickey/cFE that referenced this issue Apr 30, 2021
@jphickey
Fix nasa#1393, Move CFE_FS_RunBackgroundFileDump to internal API
8201deb 
This function should only be called internally from ES and
therefore does not need to be in public API.
jphickey added a commit to jphickey/cFE that referenced this issue May 6, 2021
@jphickey
Fix nasa#1393, Move CFE_FS_RunBackgroundFileDump to internal API
5d3996e 
This function should only be called internally from ES and
therefore does not need to be in public API.
astrogeco added a commit that referenced this issue May 11, 2021
@astrogeco
Merge pull request #1463 from jphickey/fix-1417-cfe-coverage-stubs
fc766c5 
Fix #1417, #1387, #1393, generated coverage stubs for CFE core
@astrogeco astrogeco mentioned this issue May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-41 enhancement
Projects
None yet
Milestone
Caelum
1 participant
@skliper