Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement single pattern for command handler returns #1527

Open
skliper opened this issue May 14, 2021 · 0 comments · May be fixed by #2302
Open

Implement single pattern for command handler returns #1527

skliper opened this issue May 14, 2021 · 0 comments · May be fixed by #2302

Comments

@skliper
Copy link
Contributor

skliper commented May 14, 2021

Is your feature request related to a problem? Please describe.

  • ES ignores command handler returns, just returns CFE_SUCCSS (increments counters within handler)
  • EVS captures the return and increments appropriate counter as part of the main command processing routine
  • TBL defines CFE_TBL_CmdProcRet_t but doesn't use it consistently, example:
    int32 CFE_TBL_AbortLoadCmd(const CFE_TBL_AbortLoadCmd_t *data);

    extern CFE_TBL_CmdProcRet_t CFE_TBL_DumpToFile(const char *DumpFilename, const char *TableName,
    const void *DumpDataAddr, size_t TblSizeInBytes);

Describe the solution you'd like
Utilize a consistent pattern. Suggest using CFE_Status_t and defined error types. This allows command handlers to use APIs and not need to convert error codes.

Describe alternatives you've considered
None

Additional context
Code review, also related to issue #921 to consistently use CFE_Status_t

Requester Info
Jacob Hageman - NASA/GSFC

thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Apr 21, 2023
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Dec 14, 2023
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Jan 25, 2024
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Mar 24, 2024
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Jul 9, 2024
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant