ES branch missing coverage in CFE_ES_GenPoolRecyclePoolBlock and CFE_ESGenPoolCreatePoolBlock, NULL pointer check

[skliper]

Is your feature request related to a problem? Please describe.
The NULL pointer check in CFE_ES_GenPoolRecyclePoolBlock would require either exposing this internal routine or getting really lucky corrupting the record from a separate task since it's valid from the calling function.

     119                 :         37 :     BucketPtr = CFE_ES_GenPoolGetBucketState(PoolRecPtr, BucketId);
     120 [ +  - ][ +  + ]:         37 :     if (BucketPtr == NULL || BucketPtr->RecycleCount == BucketPtr->ReleaseCount || BucketPtr->FirstOffset == 0)
                 [ +  + ]

here:

cFE/modules/es/fsw/src/cfe_es_generic_pool.c

Lines 119 to 120 in e5d4ed9

	BucketPtr = CFE_ES_GenPoolGetBucketState(PoolRecPtr, BucketId);
	if (BucketPtr == NULL || BucketPtr->RecycleCount == BucketPtr->ReleaseCount || BucketPtr->FirstOffset == 0)

Same pattern in CFE_ES_GenPoolCreatePoolBlock:

     180                 :         31 :     BucketPtr = CFE_ES_GenPoolGetBucketState(PoolRecPtr, BucketId);
     181         [ -  + ]:         31 :     if (BucketPtr == NULL)
     182                 :            :     {
     183                 :            :         /* no buffers in pool to create */
     184                 :          0 :         return CFE_ES_BUFFER_NOT_IN_POOL;
     185                 :            :     }

here

cFE/modules/es/fsw/src/cfe_es_generic_pool.c

Lines 180 to 185 in e5d4ed9

	BucketPtr = CFE_ES_GenPoolGetBucketState(PoolRecPtr, BucketId);
	if (BucketPtr == NULL)
	{
	/* no buffers in pool to create */
	return CFE_ES_BUFFER_NOT_IN_POOL;
	}

Describe the solution you'd like
Questionable usefulness, since it can likely only be hit if a pool without a mutex is shared between tasks and access is not serialized (BAD!). If the check does remain, could just expose the internal function to force the failure.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

[avan989]

I'll work on this. @jphickey @skliper is there any reason why these 2 functions shouldn't be exposed for unit test?