Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent results from CFE_ES_SYSLOG_APPEND and CFE_ES_WriteToSysLog #449

Closed
skliper opened this issue Jan 2, 2020 · 0 comments · Fixed by #1076 or #1109
Closed

Consistent results from CFE_ES_SYSLOG_APPEND and CFE_ES_WriteToSysLog #449

skliper opened this issue Jan 2, 2020 · 0 comments · Fixed by #1076 or #1109
Labels
bug
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Jan 2, 2020

Is your feature request related to a problem? Please describe.
From #409, CFE_ES_WriteToSysLog:

Upon additional review - the only "extra" thing that CFE_ES_WriteToSyslog does is a final call to OS_printf to duplicate the syslog message onto the console, which wouldn't be done when calling the functions individually.

In particular, this means that any syslog messages generated in the CDS use case wouldn't appear on the console. This could be a valid concern/issue that might warrant a fix.

Describe the solution you'd like
Consistent behavior

Requester Info
Jacob Hageman - NASA/GSFC
skliper added a commit to skliper/cFE that referenced this issue Jan 7, 2021
@skliper
Fix nasa#449, Add OS_printf to CFE_ES_SYSLOG_APPEND
73717b8
@skliper skliper mentioned this issue Jan 7, 2021
Merged
@skliper skliper added this to the 7.0.0 milestone Jan 11, 2021
@astrogeco astrogeco added bug and removed enhancement labels Jan 21, 2021
astrogeco added a commit that referenced this issue Jan 21, 2021
@astrogeco
Merge pull request #1076 from skliper/fix449-consistent_log
bd87123 
Fix #449, Add OS_printf to CFE_ES_SYSLOG_APPEND
@astrogeco astrogeco mentioned this issue Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco