Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete coverage test for src/sb #471

Closed
avan989 opened this issue Jan 9, 2020 · 0 comments · Fixed by #1668 or #1665
Closed

Incomplete coverage test for src/sb #471

avan989 opened this issue Jan 9, 2020 · 0 comments · Fixed by #1668 or #1665
Assignees
@jphickey
Labels
enhancement unit-test
Milestone
Caelum

Comments

@avan989
Copy link
Contributor

avan989 commented Jan 9, 2020

Is your feature request related to a problem? Please describe.
Current coverage: 99.7 %

Missing code coverage for the following:
cfe_sb_api.c

CFE_SB_SetPipeOpts

     433             :         /* shouldn't happen... */
     434           0 :         return Status;

CFE_SB_SendMsgFull

   1395          23 :         if(DestPtr == NULL)
    1396             :         {
    1397           0 :           break;

cfe_sb_task.c
CFE_SB_TaskMain

    106             :             /* Process cmd pipe msg */
     107           0 :             CFE_SB_ProcessCmdPipePkt();

CFE_SB_AppInit

    203          11 :     if(CFE_PLATFORM_EVS_MAX_EVENT_FILTERS < CfgFileEventsToFilter){
     204           0 :       CfgFileEventsToFilter = CFE_PLATFORM_EVS_MAX_EVENT_FILTERS;

Requester Info
Anh Van, NASA Goddard
@skliper skliper added this to the 6.8.0 milestone Feb 25, 2020
@skliper skliper modified the milestones: 6.8.0, 7.0.0 Jun 5, 2020
@skliper skliper changed the title Incomplete unit test for src/sb Incomplete coverage test for src/sb Jan 11, 2021
@jphickey jphickey self-assigned this Jul 15, 2021
@jphickey jphickey mentioned this issue Jul 15, 2021
Closed
jphickey added a commit to jphickey/cFE that referenced this issue Jul 15, 2021
@jphickey
Fix nasa#471, improve SB coverage test
a108adc 
Add test cases to exercise all functions, lines, and branches to
the extent reasonably possible.  Improves the coverage stats
significantly.

Remaining uncovered lines/branches are not possible to be reached
due to the way the code is structured, or because it would require
an alternate implementation of SBR (note that SB+SBR are currently
tested as a single unit, even though they are technically separate
modules now).
jphickey added a commit to jphickey/cFE that referenced this issue Jul 15, 2021
@jphickey
Fix nasa#471, improve SB coverage test
947d723 
Add test cases to exercise all functions, lines, and branches to
the extent reasonably possible.  Improves the coverage stats
significantly:

  functions 98.9% -> 100%
  lines 96.4% -> 99.8%
  branches 87.1% -> 94.9%

Remaining uncovered lines/branches are not possible to be reached
due to the way the code is structured, or because it would require
an alternate implementation of SBR (note that SB+SBR are currently
tested as a single unit, even though they are technically separate
modules now).  For example, the "direct" SBR implementation cannot
have collisions, hence the collision handling in SB cannot be
reached.  Making stubs for SBR may allow this to be tested.
@jphickey jphickey mentioned this issue Jul 15, 2021
Merged
astrogeco added a commit that referenced this issue Jul 21, 2021
@astrogeco
Merge pull request #1668 from jphickey/fix-471-sb-coverage
c71a27e 
Fix #471, improve SB coverage test
@astrogeco astrogeco mentioned this issue Jul 21, 2021
Merged
paulober pushed a commit to paulober/cFE that referenced this issue Aug 1, 2021
@jphickey
Fix nasa#471, improve SB coverage test
f6a9bb7 
Add test cases to exercise all functions, lines, and branches to
the extent reasonably possible.  Improves the coverage stats
significantly:

  functions 98.9% -> 100%
  lines 96.4% -> 99.8%
  branches 87.1% -> 94.9%

Remaining uncovered lines/branches are not possible to be reached
due to the way the code is structured, or because it would require
an alternate implementation of SBR (note that SB+SBR are currently
tested as a single unit, even though they are technically separate
modules now).  For example, the "direct" SBR implementation cannot
have collisions, hence the collision handling in SB cannot be
reached.  Making stubs for SBR may allow this to be tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement unit-test
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #471, improve SB coverage test jphickey/cFE
cFE Integration candidate: 2021-07-20 nasa/cFE
3 participants
@jphickey @avan989 @skliper