Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests should use cFE defines instead of OS_MAX_PATH_LEN and OS_MAX_API_NAME #932

Closed
skliper opened this issue Oct 1, 2020 · 0 comments · Fixed by #1098 or #1109
Closed

Unit tests should use cFE defines instead of OS_MAX_PATH_LEN and OS_MAX_API_NAME #932

skliper opened this issue Oct 1, 2020 · 0 comments · Fixed by #1098 or #1109
Labels
bug refactor unit-test
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Oct 1, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
Scrub unit tests for OS size use vs cFE size, related to #705, #899.

Anything in IO structures should be using cFE sizes (cFE size is maximum of all platform OS maximums).

Describe the solution you'd like
OS_MAX_API_NAME -> CFE_MISSION_MAX_API_LEN
OS_MAX_PATH_LENGTH -> CFE_MISSION_MAX_PATH_LEN
In the code use sizeof instead of hard coded sizes.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC (spawned from 9/30/2020 CCB discussion)
@skliper skliper added this to the 7.0.0 milestone Oct 1, 2020
skliper added a commit to skliper/cFE that referenced this issue Jan 14, 2021
@skliper
Fix nasa#932, Update UT for CFE_MISSION* string sizing
170aac8
@skliper skliper mentioned this issue Jan 14, 2021
Merged
astrogeco added a commit to astrogeco/cFE that referenced this issue Jan 25, 2021
@astrogeco
Merge pull request nasa#1098 from skliper/fix1089-clean_strncpy
632153a 
Fix nasa#1089, Cleanup strncpy use - unit tests
Fix nasa#1089, Cleanup strncpy use - main code

Fix nasa#932, Update UT for CFE_MISSION* string sizing
skliper added a commit to skliper/cFE that referenced this issue Jan 25, 2021
@skliper
Fix nasa#932, Update UT for CFE_MISSION* string sizing
26a0e06
astrogeco added a commit that referenced this issue Jan 25, 2021
@astrogeco
Merge pull request #1098 from skliper/fix1089-clean_strncpy
a4aa481 
Fix #932 and #1089, strncpy cleanup and UT updates for mission sizing of API_LEN and PATH_LEN
@astrogeco astrogeco mentioned this issue Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug refactor unit-test
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco