Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #361, update Developer's Guide to use sample App, create markdown #362

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Fix #361, update Developer's Guide to use sample App, create markdown #362

merged 1 commit into from
Nov 7, 2019

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Oct 1, 2019

Describe the contribution
Fix #361, update to use sample app for template, update images, create markdown

Contributor Info
Anh Van, NASA Goddard

Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted

skliper
skliper requested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Looks like an extra space was added in document file name, prefer just to replace the old document
  2. Can image names be updated (cFE_Application_Developers_Guide_imageX.png)?

@avan989
Copy link
Contributor Author

avan989 commented Oct 1, 2019

updated image name, updated word doc's name

@skliper skliper requested a review from ejtimmon October 2, 2019 18:12
@skliper skliper modified the milestones: 6.7.0, 6.8.0 Oct 10, 2019
@avan989
Copy link
Contributor Author

avan989 commented Oct 29, 2019

Updated developer guide and markdown based on the comments. Not all comments was implemented, recommend giving it to someone more experiences with CFE to rewrite some of the passage/guide.

@skliper skliper added CCB:Approved Indicates code review and approval by community CCB enhancement labels Oct 31, 2019
@skliper
Copy link
Contributor

skliper commented Oct 31, 2019

CCB 20191030 - Reviewed and approved

skliper added a commit that referenced this pull request Oct 31, 2019
@skliper
CCB 20191023/30: Merge #362 #375 #376 #382
6e4c454 
Fixes #361, #373, #374, #381
Code reviewed and approved at 20191023 and 30 CCBs
@skliper skliper changed the base branch from master to ic-20191030 November 7, 2019 21:32
@skliper skliper merged commit e9f7382 into nasa:ic-20191030 Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

@ejtimmon ejtimmon Awaiting requested review from ejtimmon

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB enhancement
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.
2 participants
@avan989 @skliper