Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #101, Always increment sequence counter #419

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

CDKnightNASA
Copy link
Contributor

@CDKnightNASA CDKnightNASA commented Nov 27, 2019

Describe the contribution

Note that this means route entries will never be removed and unsubscribe messages will never be sent.

Testing performed
Built and ran the SB unit tests. All passed, with changes included in this pull req.

Expected behavior changes
Sequence ID's of messages should increment even when there's (currently) no subscribers to that message ID.

System(s) tested on:
Debian VM

Contributor Info
Christopher.D.Knight@nasa.gov

@skliper skliper changed the title Fix for ticket #101. Note that routes will never be deleted and pipes… Fix #101, Always increment sequence counter Jan 14, 2020
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could remove or mark CFE_SB_UNSUBSCRIPTION_RPT_EID as no longer generated.

Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove CFE_SB_UNSUBSCRIPTION_RPT_EID (I think this was the CCB decision?)

@CDKnightNASA
Copy link
Contributor Author

Remove CFE_SB_UNSUBSCRIPTION_RPT_EID (I think this was the CCB decision?)

will do

@CDKnightNASA
Copy link
Contributor Author

CDKnightNASA commented Jan 18, 2020

I believe I've properly squashed the branch, removed the unused EID, added unit tests...anything else?

FYI for me what worked:

% git checkout branch
% git log # look for the first SHA before the branch
% git reset --soft SHA
% git commit -m 'new commit msg'
% git push origin +branch

@skliper
Copy link
Contributor

skliper commented Jan 21, 2020

CCB 20200115 - Reviewed and approved for IC pending the changes already addressed above

@skliper skliper added the CCB:Approved Indicates code review and approval by community CCB label Jan 21, 2020
@skliper skliper changed the base branch from master to ic-20200121 January 21, 2020 22:41
Adds logic and associated unit tests
Removes no-longer-used EID
@skliper
Copy link
Contributor

skliper commented Jan 21, 2020

Updated commit message (no code change)

@skliper skliper merged commit 108d8e1 into nasa:ic-20200121 Jan 21, 2020
@skliper skliper added this to the 6.8.0 milestone Jun 1, 2020
@skliper skliper linked an issue Sep 24, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB enhancement
Projects
None yet
2 participants