Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #561, Add branch coverage reporting #562

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Mar 17, 2020

Describe the contribution
Fix #561, Adds branch coverage and removes no-longer-needed report file manipulation to exclude unit test code from coverage report

Testing performed
Steps taken to test the contribution:

  1. Standard build/test/lcov (same as enhanced CI)
  2. Confirmed branch coverage reported (~91%)

Expected behavior changes
No changes to operational behavior

System(s) tested on

  • Hardware: cFS Dev Server 3
  • OS: Ubuntu 18.04
  • Versions: Master bundle w/ this change

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 6.8.0 milestone Mar 17, 2020
@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Mar 17, 2020
@astrogeco
Copy link
Contributor

CCB Approved - 20200318

@astrogeco astrogeco added CCB - 20200318 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Mar 18, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate March 23, 2020 16:54
@astrogeco astrogeco merged commit 13213fd into nasa:integration-candidate Mar 23, 2020
@skliper skliper deleted the fix561-branch-cov-reporting branch February 1, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add branch coverage reporting and remove no longer necessary removal of unit test files
2 participants