Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX-20200902, Fix sb unit test setup issue #866

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Sep 4, 2020

Describe the contribution
Fix integration-candidate - there was some convoluted test setup logic which actually caused some of the tests to be skipped and the CleanApp API test wasn't proceeded by a test reset so the event count didn't match expected. Caused a TTF.

Basically just straightened out the setup (no actual test changes.)

Testing performed
Make, make test - passed

Expected behavior changes
Tests pass, no TTF.

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: bundle IC + this change

Additional context
nasa/cFS#136

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Sep 4, 2020

@yammajamma @astrogeco - fixes nasa/cFS#136 CI

@skliper skliper added this to the 7.0.0 milestone Sep 4, 2020
@astrogeco astrogeco changed the base branch from main to integration-candidate September 4, 2020 19:36
@astrogeco astrogeco merged commit 8b9a3db into nasa:integration-candidate Sep 4, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 4, 2020
@skliper skliper deleted the HOTFIX-sb-unit-tests branch February 1, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants