-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve build warnings #12
Comments
Okay, I try this issue. |
Heads up on the first one, preference is to fix the format vs cast. |
On printf statements it is generally not possible to fix the format when the type is a fixed width int (i.e. uint32). A cast is generally needed here. My recommendation is to use %ld conversion AND cast the argument to "long int" as well. |
stringLength is not a fixed point int. It's defined as long, just use %ld. |
Yes I concur then, if it is actually "long" then no cast. |
Any updates on this issue? Do you have an expected completion date? |
Not sure if you'll get this but I have been delayed in doing this ticket
because of higher priority work.
Mike
…On Fri, Jul 26, 2019, 11:53 AM skliper ***@***.***> wrote:
Assigned #12 <#12> to
@mrosburg <https://github.com/mrosburg>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=ALQYDCRA4NKITQO2KXU6CZTQBMTW3A5CNFSM4ICMQJUKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSXF4ORQ#event-2513160006>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALQYDCTJY4O2YEKZU3H6YE3QBMTW3ANCNFSM4ICMQJUA>
.
|
You can reassign it.
…On Tue, Aug 27, 2019, 8:20 AM skliper ***@***.***> wrote:
@mrosburg <https://github.com/mrosburg> - do you foresee addressing this
one soon? If not planning reassignment to @avan989
<https://github.com/avan989>. We need the build warnings resolved for the
end of summer release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=ALQYDCUNVK64FDQCGWB4FJTQGUSYVA5CNFSM4ICMQJUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5HWPMA#issuecomment-525297584>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALQYDCTKWGPGTTLC4SBNQCLQGUSYVANCNFSM4ICMQJUA>
.
|
I can do this. |
2 warnings from cc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609
/home/jhageman/cFS/cFS-dev/tools/cFS-GroundSystem/Subsystems/cmdUtil/cmdUtil.c: In function ‘ProcessStringArgument’:
/home/jhageman/cFS/cFS-dev/tools/cFS-GroundSystem/Subsystems/cmdUtil/cmdUtil.c:239:16: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘long int’ [-Wformat=]
printf("String Length is %d.\n", stringLength);
^
/home/jhageman/cFS/cFS-dev/tools/cFS-GroundSystem/Subsystems/cmdUtil/sendUdp.c: In function ‘SendUdp’:
/home/jhageman/cFS/cFS-dev/tools/cFS-GroundSystem/Subsystems/cmdUtil/sendUdp.c:74:12: warning: implicit declaration of function ‘atoi’ [-Wimplicit-function-declaration]
port = atoi(portNum);
^
The text was updated successfully, but these errors were encountered: