Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style update - only inline empty functions #88

Closed
skliper opened this issue May 23, 2020 · 0 comments · Fixed by #89 or #91
Closed

Code style update - only inline empty functions #88

skliper opened this issue May 23, 2020 · 0 comments · Fixed by #89 or #91
Labels
enhancement

Comments

@skliper
Copy link
Contributor

skliper commented May 23, 2020

Is your feature request related to a problem? Please describe.
Complaints about single line functions being inline

Describe the solution you'd like
Don't.

Describe alternatives you've considered
Ignore complaints.

Additional context
None, whitespace.

Requester Info
Jacob Hageman - NASA/GSFC, per nasa/sample_lib#23 (review)
skliper added a commit to skliper/cFS that referenced this issue May 23, 2020
@skliper
Fix nasa#88, Only inline empty functions
8f50be2
@skliper skliper mentioned this issue May 23, 2020
Merged
astrogeco added a commit that referenced this issue May 27, 2020
@astrogeco
Merge pull request #89 from skliper/fix88-code-style-update
3b3dc08 
Fix #88, Only inline empty functions
@astrogeco astrogeco mentioned this issue May 29, 2020
Merged
JandlynBentley-at-NASA pushed a commit to JandlynBentley-at-NASA/cFS that referenced this issue Jun 15, 2020
@dmknutsen
Fixes nasa#88, updates comments to note that the length limit of OS_M…
f5e4c50 
…AX_PATH_LEN and OS_MAX_API_NAME includes null terminator
PaulaBosca pushed a commit to McMasterNEUDOSE/cFS that referenced this issue Aug 17, 2020
@dmknutsen
Fixes nasa#88, Add test for name too long and update comments
fa833b4
PaulaBosca pushed a commit to McMasterNEUDOSE/cFS that referenced this issue Aug 17, 2020
@astrogeco
Merge pull request nasa#398 from dmknutsen/issue_88
e374b40 
Fix nasa#88, Add test for name too long and update comments
chillfig pushed a commit to chillfig/cFS that referenced this issue Mar 17, 2022
@jphickey
Fix nasa#88, consistent application target name
140c7a8 
The application target should not have an "app" suffix.  Note
that none of the other CFS apps have a suffix either, so this
makes CF consistent with that.

Also - this removes use of "aux_source_directory" - preference
is to list the source files.
chillfig pushed a commit to chillfig/cFS that referenced this issue Mar 17, 2022
@astrogeco
Merge pull request nasa#89 from jphickey/fix-88-cf-app-name
67fbd32 
Fix nasa#88, consistent application target name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #88, Only inline empty functions skliper/cFS
Integration Candidate: 2020-05-20 nasa/cFS
1 participant
@skliper