-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #185, Apply CodeQL to Every Branch #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious if when pushing to a fork, setting the repository as nasa/cFS may actually do the analysis on the main branch in nasa/cFS?
@skliper It seems that the analysis is done on the branch the user pushes the code to, whether or not nasa/cFS is used. I tested this locally on my fork. I pushed a file and CodeQL ran automatically on push. I then went into the Actions tab and viewed the workflows for the new branch, TestPush, using the filters. Then, I changed the CodeQL workflow to remove the repository nasa/CFS code and pushed another file to that same branch. CodeQL also ran again automatically on the branch I pushed the code to which is TestPush. |
@ArielSAdamsNASA after the checkout in the workflow, could you and a version check? Just add:
after checkout and confirm the branch used in the build is your branch (when run from the fork)? You can also simplify from |
@skliper I added a version check and remove I also pushed code again to the TestPush branch on my fork after making these changes. TestPush is the branch used in the build for the CodeQL workflow. The main branch is not found in the log. Here is the full raw log: TestPushLog.txt |
Fix nasa#186, CF table name and default polling disabled
Describe the contribution
Fix #185 Removed main branch on push and pull-request. Added a timeout. Removed cFS running.
Expected behavior changes
CodeQL should run on every branch of cFS and timeout. cFS should not run, only build, since CodeQL does not require cFS to run for analysis.
System(s) tested on
CI
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal