Return value of "OS_rmdir" implementation not being passed through

[jphickey]

Describe the bug
The return value of OS_DirRemove_Impl() (the low level implementation) is not getting propagated back to the caller of OS_rmdir() as it should be.

To Reproduce
Call OS_rmdir() on a directory that shouldn't be removable, e.g. if it is not empty. The OS_DirRemove_Impl() function fails and returns OS_ERROR, but the application gets returned OS_SUCCESS.

Expected behavior
Caller should get the error code, not OS_SUCCESS.

Code snips

osal/src/os/shared/src/osapi-dir.c

Line 251 in 706f0de

OS_DirRemove_Impl(local_path);

System observed on:
Ubuntu 20.04

Additional context
Noticed this when validating return codes in #331 and #981

Reporter Info
Joseph Hickey, Vantage Systems, Inc.