Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #229, mqueue functional test #695

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Fix #229, mqueue functional test #695

merged 2 commits into from
Jan 25, 2021

Conversation

zanzaben
Copy link
Contributor

Describe the contribution
Fixes #229
Generalized queue timeout test to also test message queue functionality

Testing performed
Build and run the unit tests

Expected behavior changes
Adds 2 seconds to the unit tests

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben marked this pull request as draft December 17, 2020 18:01
@zanzaben zanzaben changed the title Fix229 mqueue functional test WIP Fix229 mqueue functional test Dec 17, 2020
@skliper
Copy link
Contributor

skliper commented Jan 4, 2021

Looks good to me.

@zanzaben zanzaben force-pushed the fix229_mqueue_functional_test branch from 549dff4 to 3a29e2e Compare January 4, 2021 14:09
@zanzaben zanzaben changed the title WIP Fix229 mqueue functional test Fix229 mqueue functional test Jan 4, 2021
@zanzaben zanzaben marked this pull request as ready for review January 4, 2021 14:10
@zanzaben zanzaben added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jan 4, 2021
jphickey
jphickey reviewed Jan 4, 2021
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly improved but there are more things I'd suggest checking (noted in comments)

src/tests/queue-test/queue-test.c Outdated Show resolved Hide resolved
src/tests/queue-test/queue-test.c Show resolved Hide resolved
src/tests/queue-test/queue-test.c Outdated Show resolved Hide resolved
src/tests/queue-test/queue-test.c Outdated Show resolved Hide resolved
@zanzaben zanzaben force-pushed the fix229_mqueue_functional_test branch from 0b6cc39 to f317639 Compare January 6, 2021 14:56
@astrogeco astrogeco added CCB-20210106 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jan 6, 2021
@astrogeco
Copy link
Contributor

CCB 2021-01-06 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate January 12, 2021 20:30
@zanzaben zanzaben changed the title Fix229 mqueue functional test Fix #229, mqueue functional test Jan 12, 2021
@astrogeco
Copy link
Contributor

@zanzaben I think you have typos in the commit messages, there's also one comment from @jphickey that wasn't addressed.

@zanzaben zanzaben force-pushed the fix229_mqueue_functional_test branch from f317639 to f445b95 Compare January 13, 2021 13:53
@zanzaben zanzaben force-pushed the fix229_mqueue_functional_test branch from f445b95 to 054720e Compare January 13, 2021 13:54
@astrogeco
Copy link
Contributor

Need to fix one more typo: commit 054720e is referring to the wrong issue number

@zanzaben zanzaben force-pushed the fix229_mqueue_functional_test branch from 054720e to f725ee4 Compare January 22, 2021 17:29
@astrogeco astrogeco merged commit bddede2 into nasa:integration-candidate Jan 25, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 25, 2021
@astrogeco
Add nasa/PSP#235 and nasa/osal#695
2f6f9d8
@astrogeco astrogeco mentioned this pull request Jan 26, 2021
Merged
@zanzaben zanzaben deleted the fix229_mqueue_functional_test branch February 23, 2021 17:15
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
@skliper
Merge pull request nasa#695 from skliper/fix491-ut-macros
7622827 
Fix nasa#491, Add UT macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphickey jphickey jphickey left review comments

@astrogeco astrogeco astrogeco left review comments

@skliper skliper Awaiting requested review from skliper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Caelum
Development

Successfully merging this pull request may close these issues.

mqueue test program
4 participants
@zanzaben @skliper @astrogeco @jphickey