Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Undocumented RPC endpoints #1449

Closed
2 of 14 tasks
telezhnaya opened this issue Jul 25, 2023 · 8 comments
Closed
2 of 14 tasks

[DOC] Undocumented RPC endpoints #1449

telezhnaya opened this issue Jul 25, 2023 · 8 comments
Labels
enhancement New feature or request Stale

Comments

@telezhnaya
Copy link
Contributor

telezhnaya commented Jul 25, 2023

Here, we have a number of undocumented RPC endpoints. + and nickname near the method means this person agreed to cover it with the doc.

  • health
  • light_client_proof - @posvyatokum
  • network_routes - @saketh-are
  • next_light_client_block
  • tier1_network_info - @saketh-are
  • EXPERIMENTAL_broadcast_tx_sync
  • EXPERIMENTAL_check_tx
  • EXPERIMENTAL_light_client_proof - @posvyatokum
  • EXPERIMENTAL_validators_ordered
  • EXPERIMENTAL_maintenance_windows
  • EXPERIMENTAL_split_storage_info
  • query:
    • view_state
    • include_proof flag

@bowenwang1996 @ailisp @mina86 @saketh-are, please tag the other authors as well

@telezhnaya telezhnaya added the enhancement New feature or request label Jul 25, 2023
@telezhnaya
Copy link
Contributor Author

Also, the flag include_proof was never documented
https://docs.near.org/api/rpc/contracts
Added by this PR
cc @mina86

@mina86
Copy link
Contributor

mina86 commented Jul 26, 2023

near/nearcore#7714

Also, the whole proof infrastructure is still work in progress so I’d argue it’s not that high priority.

@saketh-are
Copy link

saketh-are commented Aug 1, 2023

I'll send a PR documenting tier1_network_info.

We also recently added network_routes (it was merged in near/nearcore#9330 after this issue was created). I will document that one as well.

@bucanero
Copy link
Collaborator

bucanero commented Aug 2, 2023

On a side note, I think it would be super helpful for future docs, if we could auto-generate some OpenAPI reference out of the RPC node source code.
Pagoda did that for the Enhanced API, and creating /updating docs could be done quickly with any tool that turns OpenAPI json/yaml files into documentation.

@telezhnaya
Copy link
Contributor Author

@bucanero it's impossible, unfortunately, because OpenAPI does not support JSON RPC
OAI/OpenAPI-Specification#801

@bucanero
Copy link
Collaborator

bucanero commented Aug 7, 2023

Oh, I see, thanks for the feedback @telezhnaya .

I was reviewing a bit about JSON-RPC, and it seems a good option could be https://open-rpc.org/ . It's a fork of openApi, modified to accommodate JSON-RPC APIs.

Perhaps we can consider this as an alternative to find a way to auto-generate good docs for our node API

@telezhnaya
Copy link
Contributor Author

I feel it's too raw and I'm not ready to invest much time. There's only one Rust crate I've found https://lib.rs/crates/openrpc, version 0.1.0 does not sound promising to me
I think the best we can do here right now is just to suffer and wait, trying to document methods while we remember about it

Copy link

This issue has been automatically closed because it has been inactive for more than 180 days. Please reopen and prioritize this for development if it is essential.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
Archived in project
Status: Done
Development

No branches or pull requests

4 participants