store: add proof to ViewState response #7593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mina86 I think I've broken something when merging master. Can you take a look? |
mina86
reviewed
Sep 9, 2022
Yes, that’s expected. Previously iterator would fetch an unnecessary node which ended up included in the proof. With the seek_prefix change this no longer happens and the proof is one node shorter. |
mina86
reviewed
Sep 9, 2022
mina86
changed the title
mina86
approved these changes
Sep 9, 2022
I'm going to cry! Thanks for your support @mina86 |
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Introduce visited_nodes to TrieIterator which records raw bytes of all the nodes the iterator visits. Those are then returned as proof in response to ViewState request. Since the exact nodes the iterator visited are included in the proof, it is therefore possible to verify all the values returned in the state. At the moment the proof is always included. Fixes: #2076
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce visited_nodes to TrieIterator which records raw bytes of all
the nodes the iterator visits. Those are then returned as proof in
response to ViewState request. Since the exact nodes the iterator
visited are included in the proof, it is therefore possible to verify
all the values returned in the state.
At the moment the proof is always included.
Fixes: #2076