Give instructions that help to resolve a problem with missing keychain #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
reviewed
May 27, 2024
Co-authored-by: Serhii Volovyk <SergeyVolovyk@gmail.com>
volovyks
previously approved these changes
May 27, 2024
frolvanya
reviewed
May 27, 2024
src/common.rs
Outdated
| @@ -1267,7 +1267,7 @@ pub fn save_access_key_to_keychain( | |||
| keyring::Entry::new(&service_name, &format!("{}:{}", account_id, public_key_str)) | |||
| .wrap_err("Failed to open keychain")? | |||
| .set_password(key_pair_properties_buf) | |||
| .wrap_err("Failed to save password to keychain")?; | |||
| .wrap_err("Failed to save password to keychain. You may need to install secure keychain package by following this instructions: https://github.com/jaraco/keyring#using-keyring-on-headless-linux-systems")?; | |||
There was a problem hiding this comment.
- Is it okay that we have a double-space between words (
following this)? - Last sentence isn't grammatically correct, it should be
these instructionsorthis instruction(I guess first one is better) the secure keychainlooked correct in a previous version. Why an article was removed in the last commit?
frolvanya
approved these changes
May 28, 2024
frol
approved these changes
Jun 2, 2024
Merged
frol
added a commit
that referenced
this pull request
Jun 20, 2024
## 🤖 New release * `near-cli-rs`: 0.10.2 -> 0.11.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.11.0](v0.10.2...v0.11.0) - 2024-06-19 ### Added - Added loading indicators to wait for the view-account-summary command ([#349](#349)) - Added loading indicators to wait for the create-account (sponsor-by-faucet-service) command ([#339](#339)) ### Fixed - Do not fail view-account-summary command if we could not retrieve access keys list ([#344](#344)) ### Other - [**breaking**] upgraded near-dependencies to the 0.23 version ([#350](#350)) - Provide instructions that help to resolve a problem with missing keychain ([#347](#347)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that certain headless linux systems don't implement keyring. For example on WSL we can`t use keychain because it is not seted up by default. User need to install gnome-keyring with pip3, start D-bust session and unlock keychain. Close #299