Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1160: Fix storage management error message with proper amount #1222

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

lauchaves
Copy link
Contributor

Description

  • This PR fix issue #1160 from near-sdk

  • Need to add the exact_amount_display method to format yoctoNEAR values for clearer error message

  • This requires the Near-token pull request to be merged first.

Implementation

  • Added exact_amount_display to format NearToken values

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lauchaves Thank you for the contribution! Let us address #1223 to get CI green before we can merge this PR

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, bump the near-token crate version to the latest one that now includes your fix

near-token = { version = "0.2.0", features = ["serde", "borsh"] }

@lauchaves
Copy link
Contributor Author

Please, bump the near-token crate version to the latest one that now includes your fix

near-token = { version = "0.2.0", features = ["serde", "borsh"] }

@frol done!

@lauchaves
Copy link
Contributor Author

@race-of-sloths please, include me

@race-of-sloths
Copy link

race-of-sloths commented Jul 31, 2024

@lauchaves Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 1

The average score is 1

@lauchaves check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@lauchaves lauchaves requested a review from frol July 31, 2024 15:51
@lauchaves lauchaves force-pushed the 1160-fix-msg-with-proper-amount-yoctonear branch from e873582 to 1b09abb Compare July 31, 2024 16:06
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lauchaves Thank you!

@race-of-sloths score 1

@race-of-sloths
Copy link

🌟 Score recorded!

@frol, thank you for scoring this pull request in the Race of Sloths!

@frol frol enabled auto-merge (squash) July 31, 2024 18:44
@frol frol merged commit 8933fe7 into near:master Jul 31, 2024
19 checks passed
@frol frol mentioned this pull request Jul 31, 2024
@race-of-sloths
Copy link

✅ PR is finalized!

Your contribution is much appreciated with a final score of 1!
You have received 10 Sloth points for this contribution

We would appreciate your feedback or contribution idea that you can submit here

@frol frol mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants