Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1223: Fix compilation errors #1227

Conversation

lauchaves
Copy link
Contributor

Description

  • This PR fix issue #1223from near-sdk

  • Need to address the following issues:

image
image

Implementation

  • Fixed broken test: Updated the upper limit of the assertions to be more flexible, allowing for small variations in gas rewards and contract balance.
  • Fixed comments indentation

@lauchaves lauchaves force-pushed the 1223-fix-compilation-error-unexpected-cgf-condition-value branch from 2db43f0 to 6d04b17 Compare July 31, 2024 17:11
@lauchaves lauchaves force-pushed the 1223-fix-compilation-error-unexpected-cgf-condition-value branch from 6d04b17 to cf092d3 Compare July 31, 2024 17:15
@lauchaves
Copy link
Contributor Author

Hey @frol this is ready for review! 🚀

@lauchaves
Copy link
Contributor Author

@race-of-sloths pls, include me

@race-of-sloths
Copy link

race-of-sloths commented Jul 31, 2024

@lauchaves Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Are you going to win race-of-sloths this month? If so, you should speed up! Run, Sloth, run!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 2

The average score is 2

@lauchaves check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lauchaves Great!

@race-of-sloths score 2

@frol frol merged commit 1a25837 into near:master Jul 31, 2024
19 checks passed
@race-of-sloths
Copy link

🌟 Score recorded!

@frol, thank you for scoring this pull request in the Race of Sloths!

@frol frol mentioned this pull request Jul 31, 2024
@race-of-sloths
Copy link

✅ PR is finalized!

Your contribution is much appreciated with a final score of 2!
You have received 20 Sloth points for this contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants