nft_tokens return empty array if there are no tokens not error

[kay404]

If there are no tokens are minted or from_index equal to, when I call commond:

near view NFT_CONTRACT_ID nft_tokens ''

It return error:

View call: NFT_CONTRACT_ID.nft_tokens()
An error occured
Error: Querying [object Object] failed: wasm execution failed with error: FunctionCallError(HostError(GuestPanic { panic_msg: "Out of bounds, please use a smaller from_index." })).
{
  "block_hash": "AUezwdpWhfrUh5XkDDLDMGSoEEUzhjsAgATdYUxLG9vY",
  "block_height": 88141968,
  "error": "wasm execution failed with error: FunctionCallError(HostError(GuestPanic { panic_msg: \"Out of bounds, please use a smaller from_index.\" }))",
  "logs": []
}
    at JsonRpcProvider.query (/root/.nvm/versions/node/v17.1.0/lib/node_modules/near-cli/node_modules/near-api-js/lib/providers/json-rpc-provider.js:123:19)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Account.viewFunction (/root/.nvm/versions/node/v17.1.0/lib/node_modules/near-cli/node_modules/near-api-js/lib/account.js:366:24)
    at async exports.callViewFunction (/root/.nvm/versions/node/v17.1.0/lib/node_modules/near-cli/index.js:94:48)
    at async Object.handler (/root/.nvm/versions/node/v17.1.0/lib/node_modules/near-cli/utils/exit-on-error.js:52:9)
TypedError: Querying [object Object] failed: wasm execution failed with error: FunctionCallError(HostError(GuestPanic { panic_msg: "Out of bounds, please use a smaller from_index." })).
{
  "block_hash": "AUezwdpWhfrUh5XkDDLDMGSoEEUzhjsAgATdYUxLG9vY",
  "block_height": 88141968,
  "error": "wasm execution failed with error: FunctionCallError(HostError(GuestPanic { panic_msg: \"Out of bounds, please use a smaller from_index.\" }))",
  "logs": []
}
    at JsonRpcProvider.query (/root/.nvm/versions/node/v17.1.0/lib/node_modules/near-cli/node_modules/near-api-js/lib/providers/json-rpc-provider.js:123:19)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Account.viewFunction (/root/.nvm/versions/node/v17.1.0/lib/node_modules/near-cli/node_modules/near-api-js/lib/account.js:366:24)
    at async exports.callViewFunction (/root/.nvm/versions/node/v17.1.0/lib/node_modules/near-cli/index.js:94:48)
    at async Object.handler (/root/.nvm/versions/node/v17.1.0/lib/node_modules/near-cli/utils/exit-on-error.js:52:9) {
  type: 'UntypedError',
  context: undefined
}

I think it's more reasonable to return an empty array not an error.

[austinabell]

yep! Not sure how this wouldn't have been found earlier

Also not really sure why there is this check anyway, since it seems it should just return an empty vec rather than panicking here... To fix another time

[austinabell]

Thank you!