Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function call success and error metrics #7613

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Conversation

nikurt
Copy link
Contributor

@nikurt nikurt commented Sep 14, 2022

Provides visibility into the success rate of processing function call actions.
In case of errors, this PR also counts the error types and sub-types where it makes sense.

Would be useful to have shard_id in these metrics, but the runtime is not supposed to know anything about epochs, shard layouts, etc.

# HELP near_function_call_processed The number of function calls processed since starting this node
# TYPE near_function_call_processed counter
near_function_call_processed{result="FunctionCallError"} 17
near_function_call_processed{result="ok"} 1088
# HELP near_function_call_processed_function_call_errors The number of function calls resulting in function call errors, since starting this node
# TYPE near_function_call_processed_function_call_errors counter
near_function_call_processed_function_call_errors{error_type="HostError"} 17
# HELP near_function_call_processed_host_errors The number of function calls resulting in host errors, since starting this node
# TYPE near_function_call_processed_host_errors counter
near_function_call_processed_host_errors{error_type="GasLimitExceeded"} 5
near_function_call_processed_host_errors{error_type="GuestPanic"} 12

@nikurt nikurt requested a review from a team as a code owner September 14, 2022 13:39
@nikurt nikurt marked this pull request as draft September 14, 2022 13:46
@nikurt nikurt marked this pull request as ready for review September 14, 2022 14:02
@near-bulldozer near-bulldozer bot merged commit b8bc3e9 into master Sep 15, 2022
@near-bulldozer near-bulldozer bot deleted the nikurt-metrics branch September 15, 2022 11:33
nikurt added a commit that referenced this pull request Nov 9, 2022
Provides visibility into the success rate of processing function call actions.
In case of errors, this PR also counts the error types and sub-types where it makes sense.

Would be useful to have `shard_id` in these metrics, but the runtime is not supposed to know anything about epochs, shard layouts, etc.

```
# HELP near_function_call_processed The number of function calls processed since starting this node
# TYPE near_function_call_processed counter
near_function_call_processed{result="FunctionCallError"} 17
near_function_call_processed{result="ok"} 1088
# HELP near_function_call_processed_function_call_errors The number of function calls resulting in function call errors, since starting this node
# TYPE near_function_call_processed_function_call_errors counter
near_function_call_processed_function_call_errors{error_type="HostError"} 17
# HELP near_function_call_processed_host_errors The number of function calls resulting in host errors, since starting this node
# TYPE near_function_call_processed_host_errors counter
near_function_call_processed_host_errors{error_type="GasLimitExceeded"} 5
near_function_call_processed_host_errors{error_type="GuestPanic"} 12
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants