Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase timeout when checking installed Nightly extension. #1096

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Pawel-Szydlo
Copy link
Contributor

Description

When the user has a dozen extensions, Nightly has stopped detecting correctly. Nightly is injected a few milliseconds later.

Increasing the time to check whether an extension is installed solves this problem.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

pivanov
pivanov previously approved these changes Jul 17, 2024
Copy link
Collaborator

@pivanov pivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you :)

@dim-daskalov
Copy link
Contributor

Hey @Pawel-Szydlo can you please point your PR towards near:dev branch:
image

So we can merge it after that, thanks in advance.

@pivanov pivanov changed the base branch from main to dev July 19, 2024 05:23
@pivanov pivanov dismissed their stale review July 19, 2024 05:23

The base branch was changed.

@pivanov pivanov self-requested a review July 19, 2024 06:05
@pivanov pivanov merged commit af1c8a0 into near:dev Jul 19, 2024
10 checks passed
@trechriron trechriron mentioned this pull request Jul 24, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

3 participants