Refactor: reformatting python code across all the source files #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neomatrix369
added
documentation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 3.04%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
…grammar check score was computed.
…as the library returned different results since its been upgraded.
…ng related tests by updating the data, as expected results changed
…oth pinned to this version to check if they work fine across the board
… swifter has issues with certain versions of pandas
…de encoding to utf-8
… encoding to utf-8
neomatrix369
force-pushed
the
reformating-code-and-minor-fixes
branch
from
6ca2568
to
ba23ad5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 498 439 -59
Branches 74 45 -29
=========================================
- Hits 498 439 -59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Currently blocked by Windows Unicode error which are failing the Windows runners, as per https://github.com/neomatrix369/nlp_profiler/actions/runs/4401367033/jobs/7707511237 |
… before running the testscript
…nt variable to enable UTF-8
|
#73 (comment) is fixed by 378458f, 44bcc4, 1771150 |
|
Pending: sourcery refactoring fixes to merge this PR and other checks mentioned in the body/description of the PR |
…as they fail to compile or fail tests unnecessarily
…around sentiment analysis as we loose code coverage as a result
|
#73 (comment) - now resolved, next manual checks of notebooks/smoke tests |
… it from grammar checks or anything else
… to the library via PRs [skip ci]
neomatrix369
added a commit
that referenced
this pull request
Mar 13, 2023
…ixes Refactor: reformatting python code across all the source files
|
Logged a regression issue #78 on the back of reviewing the notebooks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to merge a pull request, there are a few checks:
Checklist
Please check the options that you have completed and strike-out the options that do not apply via this pull request:
./test-coverage "tests slow-tests") - this will also be visible via the Code coverage report and CI/CD task on the Pull Request- [ ] the notebooks are updated (seenotebooksfolder, read the Notebooks docs)Goal or purpose of the PR
Minor fixes and code formatting
Changes implemented in the PR
Formatting all python code and fixing minor typos in the docs. Running
blackall across the code base and making the code structure consistent. Apply refactorings suggested by Sourcery.ai across all the source files.