Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop dead_code rustc lint #4070

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix: stop dead_code rustc lint #4070

merged 1 commit into from
Apr 25, 2023

Conversation

koivunej
Copy link
Member

only happens without --all-features which is what ./run_clippy.sh uses.

@koivunej
fix: stop dead_code rustc lint
8db32ea 
only happens without `--all-features` which is what `./run_clippy.sh`
uses.
@koivunej koivunej requested a review from problame April 25, 2023 14:02
@koivunej koivunej requested review from a team as code owners April 25, 2023 14:02
@koivunej koivunej requested review from MMeent and removed request for a team April 25, 2023 14:02
@koivunej koivunej enabled auto-merge (squash) April 25, 2023 14:02
@github-actions
Copy link

github-actions bot commented Apr 25, 2023 •
edited
Loading

Test results for 8db32ea:

debug build: 219 tests run: 209 passed, 0 failed, 10 (full report)

release build: 219 tests run: 209 passed, 0 failed, 10 (full report)

@problame problame mentioned this pull request Apr 25, 2023
Closed
@problame
Copy link
Contributor

Opened #4073 to prevent this from happening in the future.

@koivunej koivunej merged commit 7f80230 into main Apr 25, 2023
@koivunej koivunej deleted the cleanup_warnings_without_all_features branch April 25, 2023 15:07
problame added a commit that referenced this pull request Apr 25, 2023
@problame
build: run clippy for powerset of features
567efd4 
This will catch compiler & clippy warnings in all feature combinations.

We should probably use cargo hack for build and test as well, but,
that's quite expensive and would add to overall CI wait times.

obsoletes #4073
refs #4070
@problame problame mentioned this pull request Apr 25, 2023
Merged
problame added a commit that referenced this pull request Apr 27, 2023
@problame
build: run clippy for powerset of features (#4077)
5b911e1 
This will catch compiler & clippy warnings in all feature combinations.

We should probably use cargo hack for build and test as well, but,
that's quite expensive and would add to overall CI wait times.

obsoletes #4073
refs #4070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMeent MMeent MMeent approved these changes

@problame problame Awaiting requested review from problame

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koivunej @problame @MMeent