Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plv8 to 3.1.8 #5230

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Update plv8 to 3.1.8 #5230

merged 1 commit into from
Sep 7, 2023

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Sep 7, 2023

Problem

We likely need this to support Postgres 16
It's also been asked by a user #5042

The latest version is 3.2.0, but it require some changes in the build script (which I haven't checked, but it didn't work right away)

Summary of changes

3.1.8       2023-08-01
            - force v8 to compile in release mode

3.1.7       2023-06-26
            - fix byteoffset issue with arraybuffers
            - support postgres 16 beta

3.1.6       2023-04-08
            - fix crash issue on fetch apply
            - fix interrupt issue

From https://github.com/plv8/plv8/blob/v3.1.8/Changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin changed the title Update plv8 to 3.2.0 Update plv8 to 3.1.8 Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

1640 tests run: 1565 passed, 0 failed, 75 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_remote_storage_backup_and_restore[True-local_fs]: release

Code coverage (full report)

  • functions: 52.7% (7572 of 14359 functions)
  • lines: 81.4% (44565 of 54773 lines)

The comment gets automatically updated with the latest test results
f8c852b at 2023-09-07T11:42:33.817Z :recycle:

@bayandin bayandin marked this pull request as ready for review September 7, 2023 11:23
@vadim2404
Copy link
Contributor

does it affect the image size?

@bayandin
Copy link
Member Author

bayandin commented Sep 7, 2023

does it affect the image size?

No, it doesn't (for compressed layers):

$  # the latest release:
$ docker manifest inspect neondatabase/compute-node-v14:release-3836 | jq '[.layers[].size] | add' | numfmt --to=si 
257M
$ docker manifest inspect neondatabase/compute-node-v15:release-3836 | jq '[.layers[].size] | add' | numfmt --to=si 
257M
$
$  # current PR:
$  docker manifest inspect neondatabase/compute-node-v14:6108808546 | jq '[.layers[].size] | add' | numfmt --to=si 
257M
$  docker manifest inspect neondatabase/compute-node-v15:6108808546 | jq '[.layers[].size] | add' | numfmt --to=si 
257M

@bayandin bayandin merged commit 1fee693 into main Sep 7, 2023
34 checks passed
@bayandin bayandin deleted the bayandin/plv8-3.2.0 branch September 7, 2023 13:21
@bayandin bayandin added the /release-notes Release notes content label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
/release-notes Release notes content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants