do not merge: Test check submodule forward progress #9074
+55
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We frequently mess up our submodule references. This adds one safeguard: it checks that the submodule references point to the corresponding REL_*_STABLE_neon branches, or to some commit descending from them. As next step, I'm thinking that we should automate things so that when you merge a PR to the 'neon' repository that updates the submodule references, the REL_*_STABLE_neon branches are automatically updated to match the submodule references. That way, you never need to manually merge PRs in the postgres repository, it's all triggered from commits in the 'neon' repository. But that's not included here.
Because the checks are fairly expensive, taking about 4 minutes.
this is supposed to pass the test
that's not what we want. The submodule is allowed to be *ahead* of the current REL_*_STABLE_neon branch.
Without 'branch', it will only check for "forward progress"x
this should fail
4968 tests run: 4798 passed, 6 failed, 164 skipped (full report)Failures on Postgres 17
Failures on Postgres 16
Flaky tests (6)Postgres 17
Postgres 16
Postgres 14
Test coverage report is not availableThe comment gets automatically updated with the latest test results
4dfbb54 at 2024-09-20T12:58:42.344Z :recycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to test PR #8949.