Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename sumneko_lua -> lua_ls #2439

Merged
merged 5 commits into from
Feb 12, 2023
Merged

feat: rename sumneko_lua -> lua_ls #2439

merged 5 commits into from
Feb 12, 2023

Conversation

figsoda
Copy link
Contributor

@figsoda figsoda commented Feb 6, 2023

@sumneko has moved lua-language-server to a new GitHub organization (@LuaLS), https://github.com/sumneko/lua-language-server now redirects to https://github.com/LuaLS/lua-language-server

In terms of popularity, there are no competing language servers named lua-language-server, and the package is named lua-language-server on repology

lspconfig currently doesn't have a rename policy for servers, require("lspconfig").sumneko_lua.setup will still work as before, just with a warning saying it has been renamed to lua_language_server. When this warning should be changed to a hard error is up for discussion.

scripts/docgen.lua Outdated Show resolved Hide resolved
@figsoda
Copy link
Contributor Author

figsoda commented Feb 7, 2023

Moved the deprecation to lua/lspconfig.lua so it works better with scripts/docgen.sh, it will also make adding and removing more aliases easier in the future. The diff also looks much cleaner on github now

@glepnir
Copy link
Member

glepnir commented Feb 8, 2023

LGTM

lua/lspconfig.lua Outdated Show resolved Hide resolved
@glepnir
Copy link
Member

glepnir commented Feb 12, 2023

could you rename it to lua_ls ? lua_language_server a bit long.

@figsoda figsoda changed the title feat: rename sumneko_lua -> lua_language_server feat: rename sumneko_lua -> lua_ls Feb 12, 2023
@glepnir glepnir merged commit 6669f2d into neovim:master Feb 12, 2023
@figsoda figsoda deleted the lua branch February 12, 2023 02:30
folke pushed a commit to folke/neodev.nvim that referenced this pull request Feb 12, 2023
AndresMpa added a commit to AndresMpa/mu-vim that referenced this pull request Feb 12, 2023
Since sumneko_lua have renamed to lua_ls I'm moving this to follow last
standard of lspconfig

Ref: neovim/nvim-lspconfig#2439
polyzen added a commit to polyzen/dotfiles that referenced this pull request Feb 12, 2023
ezradiniz added a commit to ezradiniz/dotfiles that referenced this pull request Feb 13, 2023
askoufis added a commit to askoufis/dotfiles that referenced this pull request Feb 13, 2023
- The `sumneko_lua` repo is under a new org and has been renamed to
`lua_language_server`. `nvim-lspconfig` and `mason` have already been
updated to reflect this.
- neovim/nvim-lspconfig#2439
budimanjojo added a commit to budimanjojo/nix-config that referenced this pull request Feb 20, 2023
fky2015 added a commit to fky2015/dotfiles that referenced this pull request Feb 21, 2023
victorblasco added a commit to factorialco/factorial-dotfiles that referenced this pull request Feb 22, 2023
fcsonline pushed a commit to factorialco/factorial-dotfiles that referenced this pull request Feb 23, 2023
Springok added a commit to Springok/wconfig that referenced this pull request Feb 23, 2023
djpowers added a commit to djpowers/dotfiles that referenced this pull request Feb 23, 2023
stephencottontail added a commit to stephencottontail/magic-kit that referenced this pull request Feb 25, 2023
solarshado added a commit to solarshado/lspcontainers.nvim that referenced this pull request Mar 8, 2023
solarshado added a commit to solarshado/lspcontainers.nvim that referenced this pull request Mar 8, 2023
minghongx added a commit to minghongx/nvim that referenced this pull request Mar 14, 2023
emilmgeorge added a commit to emilmgeorge/dotfiles that referenced this pull request Mar 17, 2023
Lua LSP sumneko_lua has been renamed to lua_ls
neovim/nvim-lspconfig#2439
NavidSassan added a commit to NavidSassan/dot_nvim that referenced this pull request Mar 22, 2023
SyedFasiuddin added a commit to SyedFasiuddin/.dotfiles that referenced this pull request Mar 22, 2023
keep-cloud-tr added a commit to keep-cloud-tr/pkgbuilds that referenced this pull request Mar 29, 2023
Alvis-73 added a commit to alvisLu/dotfiles that referenced this pull request Apr 2, 2023
mauroporras added a commit to mauroporras/dotfiles that referenced this pull request Apr 23, 2023
erikreinert pushed a commit to lspcontainers/lspcontainers.nvim that referenced this pull request Jun 3, 2023
* Rename "sumneko_lua" to "lua_ls"

as per neovim/nvim-lspconfig#2439

* Rename "sumneko" -> "lua_ls" everywhere else too
fky2015 added a commit to fky2015/dotfiles that referenced this pull request Jun 4, 2023
swoh816 added a commit to swoh816/Neovim-from-scratch that referenced this pull request Jul 11, 2023
sumneko_lua is deprecated as of the following commit:
neovim/nvim-lspconfig#2439
swoh816 added a commit to swoh816/Neovim-from-scratch that referenced this pull request Jul 11, 2023
sumneko_lua is deprecated as of the following commit:
neovim/nvim-lspconfig#2439
wincent added a commit to wincent/wincent that referenced this pull request Aug 1, 2023
They say you gotta switch to lua_ls. And so it is.

I believe it is just a name-change with no significant API changes:

- neovim/nvim-lspconfig#2439
taylorskalyo added a commit to taylorskalyo/pkgbuilds that referenced this pull request Sep 25, 2023
kuntau added a commit to kuntau/dotfiles that referenced this pull request Jul 12, 2024
kuntau added a commit to kuntau/dotfiles that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants