fix: add C3 library support #3309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(c3_lsp): update root directory to be able to handle project in the following order - a C3 project 'project.json', a library '.c3l' dir, and ancestor 'git' repo.
justinmk
reviewed
Sep 19, 2024
Co-authored-by: Justin M. Keyes <justinkz@gmail.com>
glepnir
reviewed
Sep 20, 2024
Comment on lines
+7
to
+14
| --look for a project directory | ||
| local path = util.root_pattern { 'project.json', 'manifest.json' }(fname) | ||
| if path ~= nil then | ||
| return path | ||
| end | ||
|
|
||
| --look for .git directory | ||
| return util.find_git_ancestors(fname) |
There was a problem hiding this comment.
Suggested change
| --look for a project directory | |
| local path = util.root_pattern { 'project.json', 'manifest.json' }(fname) | |
| if path ~= nil then | |
| return path | |
| end | |
| --look for .git directory | |
| return util.find_git_ancestors(fname) | |
| return util.root_patttern { 'project.json', 'manifest.json', '.git' }(fname) |
There was a problem hiding this comment.
@glepnir will this also work if we are editing the branch inside the '.git' directory instead of the working directory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(c3_lsp): update root directory to be able to handle project in the following order - a C3 project 'project.json', a library '.c3l' dir, and ancestor 'git' repo.